Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SSL certificates generation steps #1175

Merged
merged 1 commit into from
Apr 3, 2020
Merged

Fix SSL certificates generation steps #1175

merged 1 commit into from
Apr 3, 2020

Conversation

mmorhun
Copy link
Contributor

@mmorhun mmorhun commented Apr 1, 2020 •
edited
Loading

Signed-off-by: Mykola Morhun mmorhun@redhat.com

What does this PR do?

Makes self-signed certificate generation process correct.

Also fixes a few links in the TLS page.

What issues does this PR fix or reference?

eclipse-che/che#16366

Specify the version of the product this PR applies to.

  • current Eclipse Che version (7.10)
  • some past versions (if Google Chrome browser is used)
  • all next versions

@mmorhun mmorhun added kind/docs and removed kind/bug labels Apr 1, 2020
@tolusha
Copy link
Contributor

tolusha commented Apr 1, 2020

Does it work for Firefox as well?

@tolusha tolusha mentioned this pull request Apr 1, 2020
Closed
43 tasks
@mmorhun
Fix TLS certificates generation steps
0dd2548 
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
@mmorhun
Copy link
Contributor Author

mmorhun commented Apr 2, 2020 •
edited
Loading

@tolusha thank you, the issue is fixed now. I've tested it with Google Chrome, Firefox, Opera and MS Edge.

@tolusha
Copy link
Contributor

tolusha commented Apr 2, 2020

cool!

@mmorhun
Copy link
Contributor Author

mmorhun commented Apr 2, 2020

Thanks a lot @akurinnoy for testing this on Safari browser.

@mmorhun
Copy link
Contributor Author

mmorhun commented Apr 2, 2020 •
edited
Loading

@themr0c @boczkowska could you please take a look?

@akurinnoy
Copy link
Contributor

Works well in Safari.

@mmorhun mmorhun self-assigned this Apr 3, 2020
@mmorhun mmorhun mentioned this pull request Apr 3, 2020
Closed
@mmorhun mmorhun merged commit c003f54 into master Apr 3, 2020
@mmorhun mmorhun deleted the che-16366 branch April 3, 2020 12:45
@mmorhun mmorhun mentioned this pull request Apr 3, 2020
Merged
@rkratky rkratky restored the che-16366 branch April 3, 2020 16:26
@rkratky rkratky mentioned this pull request Apr 3, 2020
Merged
@rkratky rkratky mentioned this pull request Apr 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolusha tolusha tolusha approved these changes

@AndrienkoAleksandr AndrienkoAleksandr AndrienkoAleksandr approved these changes

@themr0c themr0c Awaiting requested review from themr0c

@mshaposhnik mshaposhnik Awaiting requested review from mshaposhnik

@yhontyk yhontyk Awaiting requested review from yhontyk

@rkratky rkratky Awaiting requested review from rkratky

@slemeur slemeur Awaiting requested review from slemeur

Assignees

@mmorhun mmorhun

Labels
kind/docs
Projects
None yet
Milestone
No milestone
5 participants
@mmorhun @tolusha @akurinnoy @AndrienkoAleksandr @che-bot